rename DumpSetup to DebugCollector #9479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume when this module was initially named, all it did was set up a dump device. But now it does a whole lot more: it runs savecore to save those dumps, it configures coreadm, it archives log files from zones, it deletes old data, etc. What's common to all of it is that it's managing the collection and archival of debug data (kernel crash dumps, process core dumps, log files, and soon other debug data). I propose calling it
DebugCollector.This PR does not change any behavior. It just renames the Rust modules (which requires renaming files), a few Rust types, a few local variables, and a function. It also updates a few comments.