DevMap should not expose cloneable references
#882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the purposes of `DevMap` is to ensure that the datapath does not inappropriately clone out and extend the lifetime of any ports. As it turns out, the code using `DevMap` is doing the right thing, but its API surface is overly permissive and should be making an `Arc::clone` or similar impossible.
zeeshanlakhani
approved these changes
Nov 13, 2025
zeeshanlakhani
left a comment
zeeshanlakhani
left a comment
There was a problem hiding this comment.
I know the review for #847 is incoming, but, as discussed, we don't want to allow for the Arc::clone of DevMaps in that work, so it would be beneficial to have this in first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the purposes of
DevMapis to ensure that the datapath does not inappropriately clone out and extend the lifetime of any ports. As it turns out, the code usingDevMapis doing the right thing, but its API surface is overly permissive and should be making anArc::cloneor similar impossible.