Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AreaSeries ConstantY2 is not implemented #662

Closed
less0 opened this issue Nov 26, 2015 · 4 comments
Closed

AreaSeries ConstantY2 is not implemented #662

less0 opened this issue Nov 26, 2015 · 4 comments
Labels
Milestone

Comments

@less0
Copy link

@less0 less0 commented Nov 26, 2015

The default behavior of the AreaSeries is to display the area between the graph and the line between the first and the last DataPoint. If no DataPoints are provided in Points2 the behavior should be to use ConstantY2, which is not implemented, yet.

I've already implemented a first basic version of it and I am only waiting for my you-take-it assignment.

I am using the latest unstable Version, WindowsForms, .NET 4.5.2

@objorke

This comment has been minimized.

Copy link
Member

@objorke objorke commented Nov 26, 2015

The comment on ConstantY2 should be updated
https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot/Series/AreaSeries.cs#L41

I think it should be "ConstantY2 is used if ItemsSource is set and DataField2 is null, or if ItemsSource is null and Points2 is empty."

@objorke

This comment has been minimized.

Copy link
Member

@objorke objorke commented Nov 26, 2015

An alternative could be to use ConstantY2 if it is not NaN. But that would be a breaking change.

@objorke objorke added the enhancement label Nov 26, 2015
@objorke

This comment has been minimized.

Copy link
Member

@objorke objorke commented Nov 26, 2015

It seems ConstantY2 is currently not used...

@objorke

This comment has been minimized.

Copy link
Member

@objorke objorke commented Nov 26, 2015

Please include examples for all cases:

  • with ItemsSource
  • null ItemsSource
  • null DataField2
  • empty Points2
    etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.