Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate all State's mutations #195

Closed
ozkriff opened this Issue Jan 27, 2018 · 1 comment

Comments

Projects
1 participant
@ozkriff
Copy link
Owner

ozkriff commented Jan 27, 2018

A follow-up of #193.

Merge state.rs and apply.rs mods in some way and expose only two mutating methods: alloc_id and apply(event).

@ozkriff ozkriff added the refactoring label Jan 27, 2018

@ozkriff ozkriff added this to the v0.5: Battle math milestone Jan 27, 2018

@ozkriff ozkriff added this to To do in v0.5 Feb 18, 2018

@ozkriff ozkriff modified the milestone: v0.5: Battle math Feb 18, 2018

@ozkriff ozkriff moved this from To do to In progress in v0.5 Jun 5, 2018

@ozkriff ozkriff moved this from In progress to To do in v0.5 Jul 3, 2018

@ozkriff ozkriff moved this from To do to In progress in v0.5 Feb 21, 2019

@ozkriff

This comment has been minimized.

Copy link
Owner Author

ozkriff commented Feb 25, 2019

The main thing that worries me is that an execute mod directly modifies schedule and effects components of the objects. These direct modification should be replaced by additional fields of the Event or ActiveEvent structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.