Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Zemeroth-specific error type #427

Closed
ozkriff opened this Issue Feb 19, 2019 · 1 comment

Comments

Projects
1 participant
@ozkriff
Copy link
Owner

ozkriff commented Feb 19, 2019

GameError::UnknownError was removed in GGEZ 0.5, so I need to create a Zemeroth-specific error enum to handle Zemeroth's logic errors.

There're a bunch ow unwraps and expects that need to be converted to normal errors:

  • expect in Sprite::new
  • expect in Sprite::from_drawable
  • expect in read_file_to_string

Related to #409
Related to ggez/ggez#590

@ozkriff ozkriff added the refactoring label Feb 19, 2019

@ozkriff ozkriff added this to To do in v0.5 via automation Feb 19, 2019

@ozkriff ozkriff moved this from To do to In progress in v0.5 Feb 20, 2019

@ozkriff

This comment has been minimized.

Copy link
Owner Author

ozkriff commented Feb 20, 2019

I can't use failure because of ggez/ggez#566 . Ok, I'll just implement an enum with a bunch of methods manually for now.

Also, looks like ZGui and ZScene need their own error types.

@ozkriff ozkriff closed this in #433 Feb 21, 2019

v0.5 automation moved this from In progress to Done Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.