Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate state mutations and add tests #439

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@ozkriff
Copy link
Owner

commented Mar 19, 2019

Sorry for the giant commit. It's a result of many evenings of work and I'm too tired to split it carefully into multiple independent PRs or even commits.

Closes #195 ("Encapsulate all State's mutations")
Closes #364 ("Integration testing")
Closes #434 ("Use derive_more::From to simplify the code")

This PR also fixes a few bugs here and there, adds some checks, adds lots of TODOs.

@ozkriff ozkriff merged commit 0e73f76 into master Mar 19, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ozkriff ozkriff deleted the i195_i364_mutability_refactoring_and_tests branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.