Bump ggez to version 0.5.0-rc.2#485
Conversation
ozkriff
left a comment
ozkriff
left a comment
There was a problem hiding this comment.
Nice! Thanks for the investigation!
Though, other changes are controversial (see review comments). Could you remove them from the PR?
| /target | ||
| /assets | ||
| /static | ||
| .DS_Store |
There was a problem hiding this comment.
I believe that a project's gitignore file should only list project-specific things and all globally ignored files should be placed in a global gitignore file - https://stackoverflow.com/questions/18393498/gitignore-all-the-ds-store-files-in-every-folder-and-subfolder
There was a problem hiding this comment.
I think adding it would serve more good than harm. I've always added .DS_Store to project repos to help make developability more seamless given there are so many developers on macOS, as most user's haven't had time to configure their global gitignore (and some aren't even aware of it).
There was a problem hiding this comment.
@ozkriff I understand your argument, but imo there is different purpose of both of those files:
- local global
.gitignoreprevents me from committing.DS_Store - project-specific
.DS_Storeprevents anyone from accidentally committing.DS_Store
I believe the later solution is a desired one. Otherwise a reviewer of the pull request has to always check whether .DS_Store was not accidentally committed.
btw. that's rustc's .gitignore
https://github.com/rust-lang/rust/blob/d85e866c0d28fce32856d200fd534ac1c2c721c8/.gitignore#L3
| [*] | ||
| indent_style=space | ||
| indent_size=tab | ||
| tab_width=4 |
There was a problem hiding this comment.
I don't believe that editorconfig is worth having in a repo when the code is always formatted with cargo-fmt (and this is checked on travis-ci)
There was a problem hiding this comment.
I think having .editorconfig may help users that use Visual Studio code, since new lines of code are formatted according to that config. See https://docs.microsoft.com/en-us/visualstudio/ide/create-portable-custom-editor-options?view=vs-2019
There was a problem hiding this comment.
@ozkriff both, my editor's (vim) and my cargo-fmt default settings are different to the one used in this repo. This file really makes life easier if you're switching between multiple projects and you don't remember/don't care what kind of formatting they use
|
@ozkriff thanks for the review. I understand your concerns. I removed unrelated changes from this pr and opened a new pr only with |
|
Thanks, merged. :) I'll think over your DS_Store and editorconfig proposals. |
3 participants
Issue #408 and #484 are both caused by the bug in ggez's screen resizing on mac os. Version
0.5.0-rc.2of ggez disabled support for hdpi screens, so there is no automatic resize at app launch. Thanks to that mouse click offset issue reported in #408 no longer exists.closes #408