Load sprites from sprites.ron file - #486
Closed
debris wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
rebased on latest master |
debris
commented
Jun 11, 2019
| const BLOOD_SPRITE_DURATION: i32 = 6; | ||
|
|
||
| lazy_static! { | ||
| static ref SPRITES: HashMap<String, SpriteInfo> = ron::de::from_str(include_str!("../../../assets/sprites.ron")) |
Contributor
Author
There was a problem hiding this comment.
include_str! loads file at compile time whereas utils::deserialize_from_file does it during runtime. Which one would you like to use?
Owner
There was a problem hiding this comment.
I definitely prefer not having any global variables, even for config-like stuff. So yeah, it should be loaded at runtime and stored as a new field in the BattleView struct I guess.
Owner
There was a problem hiding this comment.
FYI: I've started implementing what I've written above on top of your commits.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: ozkriff/zemeroth_assets#5