Skip to content

docs: Fix logic of insert within zcomponents - #491

Merged
ozkriff merged 4 commits into
ozkriff:masterfrom
ltfschoen:patch-1
Jun 11, 2019
Merged

docs: Fix logic of insert within zcomponents#491
ozkriff merged 4 commits into
ozkriff:masterfrom
ltfschoen:patch-1

Conversation

@ltfschoen

Copy link
Copy Markdown
Contributor

No description provided.

@ozkriff

ozkriff commented Jun 10, 2019

Copy link
Copy Markdown
Owner

Huh? insert is not supposed to panic if an entity exists. It even has this assert: assert!(self.get_opt(id).is_none());

@ltfschoen

Copy link
Copy Markdown
Contributor Author

@ozkriff Thanks I've updated the PR

@ozkriff ozkriff left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@ozkriff
ozkriff merged commit 1e9350f into ozkriff:master Jun 11, 2019
@ozkriff

ozkriff commented Jun 11, 2019

Copy link
Copy Markdown
Owner

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants