Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix logic of insert within zcomponents #491

Merged
merged 4 commits into from Jun 11, 2019

Conversation

@ltfschoen
Copy link
Contributor

ltfschoen commented Jun 10, 2019

No description provided.

@ozkriff

This comment has been minimized.

Copy link
Owner

ozkriff commented Jun 10, 2019

Huh? insert is not supposed to panic if an entity exists. It even has this assert: assert!(self.get_opt(id).is_none());

ltfschoen added 3 commits Jun 10, 2019
@ltfschoen

This comment has been minimized.

Copy link
Contributor Author

ltfschoen commented Jun 10, 2019

@ozkriff Thanks I've updated the PR

Copy link
Owner

ozkriff left a comment

r+

@ozkriff ozkriff merged commit 1e9350f into ozkriff:master Jun 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ozkriff

This comment has been minimized.

Copy link
Owner

ozkriff commented Jun 11, 2019

Merged, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.