Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Depth buffer problems on Letv Le 1s #248

Closed
ozkriff opened this issue Nov 30, 2016 · 7 comments
Closed

android: Depth buffer problems on Letv Le 1s #248

ozkriff opened this issue Nov 30, 2016 · 7 comments
Labels
t-bug

Comments

@ozkriff
Copy link
Owner

ozkriff commented Nov 30, 2016

Letv Le 1s, Andoid 6.0, Opengl ES 3.1, MTK6795

https://gist.github.com/ozkriff/6d7eae2d40251054d960a3e224935485
@ozkriff ozkriff added the t-bug label Nov 30, 2016
@ozkriff
Copy link
Owner Author

ozkriff commented Feb 7, 2017

This is how it looks on this phone after the firmware update:

wow.. z-fighting? bad vertex indices? something else?

@ozkriff
Copy link
Owner Author

ozkriff commented Feb 7, 2017

I'll try to update main deps and build a new apk in a few days. Maybe it'll go away on its own? :)

@ozkriff ozkriff changed the title android: Crashes on Letv Le 1s android: Depth buffer problems on Letv Le 1s Feb 13, 2017
@ozkriff
Copy link
Owner Author

ozkriff commented Feb 14, 2017

See gfx-rs/gfx#1188

@ozkriff ozkriff removed the s-active label Feb 14, 2017
@shmutalov
Copy link
Contributor

Changing a precision solves problem:
gfx-rs/gfx#1188 (comment)

@ozkriff
Copy link
Owner Author

ozkriff commented Feb 16, 2017

Ok, so we need to set highp in fragment shader only.

ozkriff added a commit that referenced this issue Feb 16, 2017
@ozkriff
#248: Hardcoded shader headers and defined precision for fragment sha…
d177030 
…der only
@ozkriff
Copy link
Owner Author

ozkriff commented Feb 16, 2017

Done in https://github.com/ozkriff/zoc/tree/WIP_248_glsl_es_precision

@shmutalov Can you check if it still works on your phone?

@shmutalov
Copy link
Contributor

@ozkriff works as expected. No problems with Z-buffer )

ozkriff added a commit that referenced this issue Feb 19, 2017
@ozkriff
#248: Hardcoded shader headers and defined precision for fragment sha…
a9d65f8 
…der only
@ozkriff ozkriff closed this as completed Feb 19, 2017
ozkriff added a commit to ozkriff/zoc_assets that referenced this issue Feb 21, 2017
@ozkriff
ozkriff/zoc#248: Removed shader headers
4b1a0e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ozkriff @shmutalov