Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

We've gone back and forth, but I think clientlenout should account fo…

…r last NULL
  • Loading branch information...
commit 35a8bf2f307dc6ef578fa4496382ed92185bf494 1 parent 8108a5d
Austin King authored November 17, 2011

Showing 1 changed file with 2 additions and 3 deletions. Show diff stats Hide diff stats

  1. 5  plugins/browserid.c
5  plugins/browserid.c
@@ -164,6 +164,7 @@ static int browserid_server_mech_step(void *conn_context,
164 164
 	syslog(LOG_DEBUG, "lup = %d clientinlen = %d", lup,
165 165
 	       clientinlen);
166 166
 
  167
+        ++lup;
167 168
 	if (lup != clientinlen) {
168 169
 		SETERROR(sparams->utils,
169 170
 			 "Client sent more data than the two fields we were expecting");
@@ -445,7 +446,7 @@ static int browserid_client_mech_step1(void *conn_context,
445 446
 	       browser_assertion, browser_audience);
446 447
 
447 448
 	/* send assertion NUL audience NUL */
448  
-	*clientoutlen = (strlen(browser_assertion) + 1 + strlen(browser_audience));
  449
+	*clientoutlen = (strlen(browser_assertion) + 1 + strlen(browser_audience) + 1);
449 450
 
450 451
 	syslog(LOG_DEBUG, "clientoutlen is going to be %u", *clientoutlen);
451 452
 
@@ -518,8 +519,6 @@ static int browserid_client_mech_step2(void *conn_context,
518 519
 	oparams->param_version = 0;
519 520
 
520 521
  cleanup:
521  
-
522  
-	/*return result;*/
523 522
 	return result;
524 523
 }
525 524
 /**

0 notes on commit 35a8bf2

Please sign in to comment.
Something went wrong with that request. Please try again.