Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image sizing #106

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@real-or-random
Copy link

real-or-random commented Jan 3, 2020

  • Load icon with the desired height. This fixes #86.
  • Add support for display scaling. This is not perfect because we currently don't redraw on changes.
 - Load icon with the desired height. This fixes #86. 
 - Add support for display scaling. This is not perfect because we currently don't redraw on changes.
@real-or-random

This comment has been minimized.

Copy link
Author

real-or-random commented Jan 3, 2020

I'm not entirely sure why set_size does not really what we want but this is way to get around the issue.

@p-e-w

This comment has been minimized.

Copy link
Owner

p-e-w commented Jan 8, 2020

Thanks for the PR, but without a clear understanding of what is actually going on here I am reluctant to merge this. Obviously, I had tested these parameters, and they were working with a previous GNOME Shell version. Therefore, this appears to be yet another API break somehow.

At minimum, I would need someone else to confirm that this really fixes the bug, and does not introduce any new ones.

@real-or-random

This comment has been minimized.

Copy link
Author

real-or-random commented Jan 8, 2020

Fwiw, I'm my version is 3.34.3 and I've been using this without any issues so far.

@p-e-w Maybe that's not enough for merging this but can you test this PR on "your" GNOME Shell version where you had tested the old code and see if breaks there? If not, that's already a good indicator that this works across multiple versions.

@p-e-w

This comment has been minimized.

Copy link
Owner

p-e-w commented Jan 11, 2020

can you test this PR on "your" GNOME Shell version

I don't use GNOME Shell anymore. I switched to Sway a while ago and have not looked back since. Therefore, Argos is in maintenance mode as far as I'm concerned. It would be good if someone else could confirm this works so I don't have to spin up a VM just for this purpose.

@real-or-random

This comment has been minimized.

Copy link
Author

real-or-random commented Jan 11, 2020

Okay, I see. Do you think it makes sense to add a big "maintenance mode" notice to the README? Maybe it's possible to find a maintainer.

@ElijahLynn

This comment has been minimized.

Copy link

ElijahLynn commented Feb 10, 2020

I don't use GNOME Shell anymore. I switched to Sway a while ago and have not looked back since. Therefore, Argos is in maintenance mode as far as I'm concerned.

Do you think it makes sense to add a big "maintenance mode" notice to the README? Maybe it's possible to find a maintainer.

Thanks, I opened an issue to discuss the future of argos in #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.