Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Support output selection and copy & paste [$65] #7

Open
p-e-w opened this Issue · 31 comments
@p-e-w
Owner

It should be possible to select, copy and paste terminal output.

There is a $65 open bounty on this issue. Add to the bounty at Bountysource.

This was referenced
@sajithdilshan

copy paste keyboard shortcuts doesn't work and no right click menu for copy past :(

@p-e-w
Owner

@sajithdilshan: That's why this bug is here.

@dealancer

confirm

@pyluyten

@p-e-w Do you think a "default selection fallback" for un-supported output unlike 'ls'? Or some selection regardless of the command?

@p-e-w
Owner

@pyluyten: I'm afraid I don't understand what you mean.

@ieee8023

+1

@MarkRijckenberg

I would like this feature too.

@simonbcn

IMHO, this bug is so urgent and important to solve it as soon as possible.

@p-e-w
Owner

IMHO, this bug is so urgent and important to solve it as soon as possible.

I respect your opinion, but I disagree. Full support for terminal emulation is much more important, both for usability reasons and because the implementation details will determine how copy & paste can be executed.

Both bugs will of course be fixed before Final Term is officially released.

@spupuz

how to select copy and paste? i'm not able.

@simonbcn

how to select copy and paste? i'm not able.

Actually it doesn't exist the copy&paste function.

@mediadoneright

+1 ... edit: totally missed your comment in the thread above... until now it wasn't clear to me if this was planned to be fixed or what the issues were.

@p-e-w p-e-w referenced this issue
Closed

Paste,Copy? #251

@didli

+1 for copy/paste
I wanted to use finalterm as my main term, but i guess it's too soon. But now i'm curious, is there really any way to achieve something similar at the moment ?

@p-e-w
Owner

Sorry, no.

@cgtx

Please also implement a "middle click" paste. That is one of my favorite features of Linux, it would be a shame for finalterm not to support it.

@karakk

What's the status on this feature? If copy-paste worked and some performance issues were solved finalterm would be usable. Now when i run 1 command i get 60% load on cpu. Its a pitty because it really is different from other terminal emulators.

@JishnuChatterjee

This is disappointing...:(
copy paste is a very basic functionality and a very essential functionality without it every other eye-candies that you introduce will go to waste.

@p-e-w
Owner

@JishnuChatterjee: I'm confused. What exactly do you find disappointing?

That the lack of copy and paste is already being tracked in this issue? That it is marked as part of the "Initial Stable Release" milestone so there will definitely be no Final Term release without copy and paste (note that this repository is not a release but an in development project, as is clearly stated everywhere from the website to the readme)?

All these things are very positive IMO so I do not see why they would disappoint anyone...

However... in case you mean that you are disappointed that copy and paste is not implemented yet, fear not! There is a very simple fix: Just submit a pull request implementing it and I promise I will consider it for merging. In case you are unfamiliar with Vala (as I was before I started Final Term), the tutorial is here: https://wiki.gnome.org/Projects/Vala/Tutorial

@p-e-w p-e-w changed the title from Support output selection and copy & paste to Support output selection and copy & paste [$10]
@p-e-w p-e-w added the Bounty label
@p-e-w p-e-w changed the title from Support output selection and copy & paste [$10] to Support output selection and copy & paste [$30]
@p-e-w p-e-w added the Bounty label
@p-e-w p-e-w changed the title from Support output selection and copy & paste [$30] to Support output selection and copy & paste [$35]
@p-e-w p-e-w added the Bounty label
@efouladi

I started working on this and I'll update you here when it's fixed

@p-e-w
Owner

@efouladi: I'm very excited to hear that you are undertaking to implement this important feature. As noted in #301, deep changes to TerminalView and TerminalOutputView are planned and will significantly affect how copy & paste can work. Could you give an outline describing how you intend to go about this so we can make sure it is compatible with what is coming? Feel free to email me if you want.

@p-e-w p-e-w changed the title from Support output selection and copy & paste [$35] to Support output selection and copy & paste [$65]
@p-e-w p-e-w added the Bounty label
@karakk
@nashley

@p-e-w I sent you an email regarding this issue (I would like to fix it, but I don't want my work to be negated by scheduled changes without knowing what they entail). Did you receive it?

@p-e-w
Owner

Yes I did, just sent you a reply :)

@nashley nashley referenced this issue from a commit in nashley/finalterm
@nashley nashley Allows for copying and pasting (no selection yet)
This is aimed at fixing #7; the next step is implementing user-based
text selection for copying. Currently, one can only copy data from
hard-coded lines (in this case, the current command input is used),
but pasting works as expected.
2f27f94
@arkocal

I think this (Vreality's latest releated commit) should be kept as a feature after implementing normal copying with selection, as this is the most common use of copying from a terminal.

@p-e-w
Owner

@arkocal: I agree, this is a really convenient idea. A simply right click menu item to copy the full line currently under the cursor would also make sense, and could be implemented with current technology as well.

@janpansa

Hi, I love finalterm, just want to know if there is some sort of an eta on the copy paste issue. I would like to paste code from the clipboard. It looks like it is being implemented in this commit nashley@2f27f94 however I dont see it in the latest build.

@nashley

@janpansa That's because I'm still working on the code (sorry, I'd like to work on it more, but I've been really busy). You can certainly use my fork for now if you wish, but you should realize that features may not be fully implemented or (more) bugs may appear.
As for when I expect to be done, I'd like to work on this project more starting next week, but I'm not positive that I'll have everything done by the end of the week.

@janpansa

@nashley Thanks for the feedback ! that's great news.

@nashley nashley referenced this issue from a commit in nashley/finalterm
@nashley nashley Allows for copying and pasting (no selection yet)
This is aimed at fixing #7; the next step is implementing user-based
text selection for copying. Currently, one can only copy data from
hard-coded lines (in this case, the current command input is used),
but pasting works as expected.
88735a6
@Eugene-msc

I have a working normal select and copy, and beginnings of column select implementation here.
Although I'm a bit stumped as to how to make column select work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.