New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API change - progress bar can be constructed with proper settings. #21
Conversation
3eeb6a4
to
14ea4ce
Compare
I fixed the Codacy complaining about non-explicit ctor, even though, I am not convinced, whether the constructor really should be explicit in this case. I cannot, however, fix the complaints about always_true::value is not used as well as are_setting::value, because Codacy is simply wrong in this case. |
I'm open to this change. Can you update the README too? I can't merge until the README is consistent with the changes. While we're at it, we should probably change enums to all lower case per https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#S-enum |
Sure I will. I should also most probably change other types than ProgressBar to use new kind of settings before merging this PR, right? |
Yeah |
@p-ranav I think all the changes are in place. Please review them carefully, especially settings that we expose. If something is still wrong, please let me know :) |
Thanks for the great work! I have a lot I can learn from your implementation. I've added comments referencing some minor things. |
Glad I could help! |
Hi there!
I would like to ask whether you would be open to the following changes.
The rationale behind them is to make it possible, to create ProgressBar object with options given as constructor parameters, as with current approach it would extremaly difficult to do so.