pkcs11: Exercise GNU calling convention at compile time #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/pkcs11-gnu
branch
from
409cc68 to
f328b4b
Compare
nmav
approved these changes
May 27, 2018
p11-kit/pkcs11-gnu.c
Outdated
| #include <p11-kit/p11-kit.h> | ||
| #include <p11-kit/iter.h> | ||
| #include <p11-kit/pin.h> | ||
| #include <p11-kit/uri.h> |
There was a problem hiding this comment.
I'm wondering whether the compiler could ignore some type errors if the code is not used. nevertheless this seems to catch the existing issue.
There was a problem hiding this comment.
I added references to the defined symbols so that the declarations are actually used.
Also this file is split into 3 (generated): iter.gnu.c, pin.gnu.c, and uri.gnu.c, so that the type declarations in other files do not take effect.
ueno
force-pushed
the
wip/dueno/pkcs11-gnu
branch
2 times, most recently
from
2e695db to
4b7e6e8
Compare
ueno
force-pushed
the
wip/dueno/pkcs11-gnu
branch
from
4b7e6e8 to
db92b71
Compare
Schamschula
added a commit
to macports/macports-ports
that referenced
this pull request
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.