Javascript protocol parser is not in line with larger messages #83

Open
gappleto97 opened this Issue Sep 1, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@gappleto97
Collaborator

gappleto97 commented Sep 1, 2016

  1. The size of a Buffer cannot exceed 1GiB in some implementations, 2GiB in others. This means that packets cannot be larger than this, and that received messages cannot be larger than this.
@gappleto97

This comment has been minimized.

Show comment
Hide comment
@gappleto97

gappleto97 Sep 1, 2016

Collaborator

Links to #69

Collaborator

gappleto97 commented Sep 1, 2016

Links to #69

@gappleto97

This comment has been minimized.

Show comment
Hide comment
@gappleto97

gappleto97 Sep 1, 2016

Collaborator

A data structure level way to fix this would be to implement an extended Buffer type. This is easier on the Javascript side since there is no such limitation on the array size. The standard defines that as 232-1 anyhow, which is larger than the maximum the current protocol allows.

Collaborator

gappleto97 commented Sep 1, 2016

A data structure level way to fix this would be to implement an extended Buffer type. This is easier on the Javascript side since there is no such limitation on the array size. The standard defines that as 232-1 anyhow, which is larger than the maximum the current protocol allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment