Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove document meta #472

Merged
merged 6 commits into from Jan 13, 2023
Merged

Remove document meta #472

merged 6 commits into from Jan 13, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jan 6, 2023

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header
  • Check if descriptions and terminology match handbook content (and visa-versa)

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 91.21% // Head: 91.07% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (5b9450f) compared to base (bf32fda).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   91.21%   91.07%   -0.14%     
==========================================
  Files         105      105              
  Lines        2924     2924              
  Branches       45       45              
==========================================
- Hits         2667     2663       -4     
- Misses        257      261       +4     
Impacted Files Coverage Δ
p2panda-rs/src/document/document.rs 95.50% <77.77%> (-4.50%) ⬇️
p2panda-rs/src/test_utils/db/stores/document.rs 96.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sandreae sandreae marked this pull request as ready for review January 6, 2023 15:39
@sandreae
Copy link
Member Author

@adzialocha if you get the chance to have a peek at this that would be awesome, it's a slight blocker for the other PRs I'm working on. 🙏 🙏

@adzialocha adzialocha self-requested a review January 13, 2023 11:25
Copy link
Member

@adzialocha adzialocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you for all the refactoring niceness ✨

p2panda-rs/src/document/document.rs Outdated Show resolved Hide resolved
@sandreae
Copy link
Member Author

Thanks!!

Looking good! Thank you for all the refactoring niceness sparkles

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants