Trait definitions for atomic write transactions - #755
Merged
Conversation
adzialocha
marked this pull request as ready for review
May 27, 2025 14:14
adzialocha
requested review from
mycognosist and
sandreae
and removed request for
sandreae
May 27, 2025 14:14
sandreae
approved these changes
Jul 13, 2025
sandreae
left a comment
Member
There was a problem hiding this comment.
All looks very good, excited to start working with these new interfaces :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces trait definitions for expressing atomic write transactions. This will be required to separate store methods into read and write queries and allow crash-resiliant write transactions across the whole p2panda stack.
Next Steps:
OperationStoreandLogStoreWriteToStoretrait onOperationOperationStore,LogStore, later probablyEncryptionStoreandAuthStore, etc. should live (either inp2panda-storeor in their regarding crates)📋 Checklist
CHANGELOG.md