Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on windows #27

Closed
juliangruber opened this issue Nov 4, 2019 · 2 comments · Fixed by #29
Assignees

Comments

@juliangruber
Copy link
Member

@juliangruber juliangruber commented Nov 4, 2019

I'm currently investigating cli build failures on Windows, and realized sdk-js doesn't test there yet. Travis has windows available:

os:
  - linux
  - windows

And this is what the cli is currenlty doing using github actions:

name: Node CI
on: [push]
jobs:
  build:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        node-version: [8.x, 10.x, 12.x]
        os: [ubuntu-latest, windows-latest]
    steps:
    - uses: actions/checkout@v1
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - name: Use latest npm
      run: npm install -g npm@latest
    - name: npm install, build, and test
      run: |
        npm ci
        npm test

If we add tests here we can gain more confidence in cross OS support and help troubleshooting as well.

@dpaez dpaez self-assigned this Nov 5, 2019
@dpaez

This comment has been minimized.

Copy link
Contributor

@dpaez dpaez commented Nov 5, 2019

Cool, @juliangruber the cli is using both, travis and gh actions?

@juliangruber

This comment has been minimized.

Copy link
Member Author

@juliangruber juliangruber commented Nov 5, 2019

It's just using gh actions right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.