Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing validation error when updating archive #30

Closed
juliangruber opened this issue Nov 5, 2019 · 1 comment · Fixed by #31
Assignees
Labels
bug
Milestone

Comments

@juliangruber
Copy link
Member

@juliangruber juliangruber commented Nov 5, 2019

When you init an archive with an empty title, a ValidationError will be thrown. When you update an archive to set its title to empty, no errors is thrown. So I think the update method is missing validation.

@juliangruber juliangruber added the bug label Nov 5, 2019
@dpaez

This comment has been minimized.

Copy link
Contributor

@dpaez dpaez commented Nov 5, 2019

on it 🏃

@dpaez dpaez self-assigned this Nov 6, 2019
@dpaez dpaez added this to the 0.2.7 milestone Nov 6, 2019
@dpaez dpaez closed this in #31 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.