Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls inconsistent #84

Open
juliangruber opened this issue Feb 13, 2020 · 1 comment
Open

urls inconsistent #84

juliangruber opened this issue Feb 13, 2020 · 1 comment
Labels
bug
Milestone

Comments

@juliangruber
Copy link
Member

@juliangruber juliangruber commented Feb 13, 2020

I just noticed that the sdk writes to dat.json parents: [encode(key)], authors: ['dat://${encode(key)}']. I think it would be more consistent for the consumer if both either had the dat:// prefix or neither.

@juliangruber

This comment has been minimized.

Copy link
Member Author

@juliangruber juliangruber commented Feb 13, 2020

Actually it seems to depend on which url the consumer passes in when creating/updating the module's parent field, so that doesn't seem to get sanitized.

@dpaez dpaez added this to the 0.5.1 milestone Feb 13, 2020
@dpaez dpaez added the bug label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.