Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date error #72

Merged
merged 7 commits into from Feb 4, 2020
Merged

date error #72

merged 7 commits into from Feb 4, 2020

Conversation

@dpaez
Copy link
Contributor

dpaez commented Feb 4, 2020

This closes #71 #70

It also removes hyperdiscovery since it was no longer used.

dpaez added 5 commits Feb 4, 2020
@dpaez dpaez added the bug label Feb 4, 2020
@dpaez dpaez added this to the 0.4.3 milestone Feb 4, 2020
@dpaez dpaez self-assigned this Feb 4, 2020
validation.js Outdated Show resolved Hide resolved
dpaez and others added 2 commits Feb 4, 2020
Co-Authored-By: Julian Gruber <julian@juliangruber.com>
@dpaez

This comment has been minimized.

Copy link
Contributor Author

dpaez commented Feb 4, 2020

I just change the +date to a date.getTime() which is equivalent and bit more clear.

@dpaez dpaez merged commit a0594f1 into master Feb 4, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@dpaez dpaez deleted the dpaez/date-error-cli branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.