Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: unpublish method #78

Merged
merged 9 commits into from Feb 7, 2020
Merged

New: unpublish method #78

merged 9 commits into from Feb 7, 2020

Conversation

@dpaez
Copy link
Contributor

dpaez commented Feb 6, 2020

This PR adds a new method: unpublish. It also renames the register method to publish.

Closes #73

Notes:

  • the method is checking if the profile is writable, if it isn't it will return (displays a message only if verbose mode is enabled). We can throw an error too.
  • the SDK is not keeping a single "user profile". It creates modules that can be content or profile.
dpaez added 5 commits Feb 6, 2020
@dpaez dpaez added this to the 0.5.0 milestone Feb 6, 2020
@dpaez dpaez self-assigned this Feb 6, 2020
@juliangruber

This comment has been minimized.

Copy link
Member

juliangruber commented Feb 7, 2020

  • the method is checking if the profile is writable, if it isn't it will return (displays a message only if verbose mode is enabled). We can throw an error too.

It would be surprising to me if an error isn't thrown. Is there a reasoning why not to throw?

  • the SDK is not keeping a single "user profile". It creates modules that can be content or profile.

SGTM!

Copy link
Member

juliangruber left a comment

..otherwise, LGTM!

README.md Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
dpaez and others added 4 commits Feb 7, 2020
Co-Authored-By: Julian Gruber <julian@juliangruber.com>
…paez/unpublish
@dpaez dpaez requested a review from juliangruber Feb 7, 2020
@dpaez dpaez merged commit 6f39f92 into master Feb 7, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@dpaez dpaez deleted the dpaez/unpublish branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.