Add cluster map to home page #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dirkcuys I ended up putting the environment variables in the _config.yml file. Can you add a production config file on Travis, that would override the first one? As suggested here: https://keirwhitaker.com/blog/setting-development-variables-in-jekyll/
The production config would just need to override the settings for
mapbox_access_tokenanddefault_base_api_endpoint. The default endpoint on production should be learningcircles.p2pu.org. The mapbox access token in the current config file is from my personal account, so I think it's fine to have that on github and use it for development, but I think we should create a P2PU account on mapbox and generate a new access token there for use on production.