Skip to content

Check the COMPILE and LINK status when building shaders for RegalIff #10

Merged
merged 1 commit into from Aug 30, 2012

3 participants

@greggman

Checking the log only is not valid GL. GL is not required to
return anything in the logs ever nor are they required to be
clear on success.

@greggman greggman Check the COMPILE and LINK status when building shaders for RegalIff
Checking the log only is not valid GL. GL is not required to
return anything in the logs ever nor are they required to be
clear on success.
5da8892
@greggman

honestly these should probably be some kind of ASSERT since the if the iff code ever generates a bad shader it's a bug right?

@casseveritt
p3 member

Agreed, we probably do need an assert if the iff generated code fails to compile or link.

@nigels-com

OK, I'll look at merging in some variation of this.

@nigels-com nigels-com merged commit 5da8892 into p3:master Aug 30, 2012
@nigels-com

Merged in, thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.