Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.11 is mislabeled[BUG] #29

Closed
ravingdragoon opened this issue Oct 2, 2021 · 2 comments
Closed

V2.0.11 is mislabeled[BUG] #29

ravingdragoon opened this issue Oct 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ravingdragoon
Copy link

Module Version: 2.0.11

Describe the bug
On the Forge the version number for 2.0.11 is labeled as 2.011. This is causing the Forge to see all new versions as older because 2.011 is greater than 2.0.x

image

@ravingdragoon ravingdragoon added the bug Something isn't working label Oct 2, 2021
@kakaroto
Copy link

kakaroto commented Oct 3, 2021

@p4535992 That was because the tag was mislabeled when you did the release :
https://github.com/p4535992/foundryvtt-arms-reach/releases/tag/v2.011
Even if the module.json had the correct 2.0.11 in it, the github action overrides that value with the version as defined by the tag name.
See https://github.com/p4535992/foundryvtt-arms-reach/blob/v2.011/.github/workflows/release.yml#L40
I've manually renamed 2.011 into 2.0.11 in our database. Thanks for letting us know about it.

@p4535992
Copy link
Owner

p4535992 commented Oct 3, 2021

@p4535992 That was because the tag was mislabeled when you did the release : https://github.com/p4535992/foundryvtt-arms-reach/releases/tag/v2.011 Even if the module.json had the correct 2.0.11 in it, the github action overrides that value with the version as defined by the tag name. See https://github.com/p4535992/foundryvtt-arms-reach/blob/v2.011/.github/workflows/release.yml#L40 I've manually renamed 2.011 into 2.0.11 in our database. Thanks for letting us know about it.

Ty for the fast fix.

@p4535992 p4535992 closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants