Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null clears on upgrade #23

Closed
KindarConrath opened this issue Nov 17, 2017 · 16 comments
Closed

Null clears on upgrade #23

KindarConrath opened this issue Nov 17, 2017 · 16 comments

Comments

@KindarConrath
Copy link

I noticed that if I have been using a Null cube and I decide I want it bigger, upgrading wipes the inventory.

It would be nice to keep the inventory when upgrading, maybe allow a self craft MKII->MKII to clear the item if desired

@p455w0rd p455w0rd added the bug label Nov 17, 2017
@p455w0rd
Copy link
Collaborator

That is how it's supposed to function..i'll look into it, thanks for reporting!

@KindarConrath
Copy link
Author

KindarConrath commented Nov 17, 2017

if its actually a bug (not a feature suggestion) then I will do a bit of info reporting!

MC 1.12.2
FV: 14.23.0.2531
DN: 1.0.13

in DW20 1.12.2 pack
tested on a server

in SP worked fine - testing again on server

@KindarConrath
Copy link
Author

nvm, tried again, can't duplicate... not certain what happened

@KindarConrath
Copy link
Author

issue is intermittent, usually upgrades just fine, rarely wipes inventory

@KindarConrath KindarConrath reopened this Nov 17, 2017
@p455w0rd
Copy link
Collaborator

looking at the code..it should never work lol..I didn't implement that in 1.12..i'll get it figured out..thanks again :)

@KindarConrath
Copy link
Author

np, i'm still doing some research, I think I have found it, just doing some testing in an isolated instance

@p455w0rd
Copy link
Collaborator

@KindarConrath
Copy link
Author

ok, clicking on the result box+panes->upgrade works
SHIFT+clicking on the result box+panes-SHIFT>upgrade clears inventory

tested in instance with JUST DN & JEI

@p455w0rd
Copy link
Collaborator

erm..I don't quite understand lol possible you can make a gif/recording of this happening? (ShareX is an awesome program for this if you don't have one)

@KindarConrath
Copy link
Author

will do

@p455w0rd
Copy link
Collaborator

just reproduced it..VERY weird..it seems the event doesn't fire when shit-clicking out of the result slot..I'll have to hack something in to get that to function properly

@KindarConrath
Copy link
Author

darn, and I downloaded & learned how to use ShareX, created a GIF just for you!

@p455w0rd
Copy link
Collaborator

the event does get fired, but I think I know what's going on..this is a good find..I'll have to implement a custom recipe for this..thanks for all of your help :)

@KindarConrath
Copy link
Author

NP, glad I could help :) I love bug hunting!

@p455w0rd
Copy link
Collaborator

@p455w0rd
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants