Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to 3 PSA tests that are causing the build to fail #1862

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@jafingerhut
Copy link
Contributor

commented Apr 18, 2019

Two of them are passing now, and should be removed from the XFAIL list.

One of them was written in a way that it was passing, but it should
not have been. Updated the STF test so it fails. A separate PR on
behavioral-model code is required to make that test pass.

Make changes to 3 PSA tests that are causing the build to fail
Two of them are passing now, and should be removed from the XFAIL list.

One of them was written in a way that it was passing, but it should
not have been.  Updated the STF test so it fails.  A separate PR on
behavioral-model code is required to make that test pass.

@jafingerhut jafingerhut requested a review from peteli3 Apr 18, 2019

@jafingerhut

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

@derekso1 FYI

@jafingerhut jafingerhut requested review from cc10512 and mbudiu-vmw Apr 18, 2019

@jafingerhut

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

I believe that until this PR is merged, all other PRs will fail the automated tests.

Until a recent change made to behavioral-model for implementing more of the PSA architecture, several STF tests for PSA programs in p4c were marked as XFAIL, and with that recent behavioral-model change several of them are working now, so should no longer be XFAIL.

# This packet should be dropped. We send it into port 0, because if
# there are no packets sent into nor expected on port 0, then the test
# infrastructure does not check any of the packets that come out port
# 0, or whether the right number come out port 0.

This comment has been minimized.

Copy link
@peteli3

peteli3 Apr 18, 2019

Contributor

Ahh we were unaware of this. So it would've passed since this check because the "expect" check wouldn't have happened anyway.

Is this specific to port 0; do you know if there are other ports that have this behavior? @jafingerhut

This comment has been minimized.

Copy link
@jafingerhut

jafingerhut Apr 18, 2019

Author Contributor

This is not specific to port 0. If there is a port number mentioned in any packet or expect statement of an STF file, then the test infrastructure will already do complete checking of every packet that comes out of that port, or does not come out of that port but is expected to.

If a port number is mentioned in no packet or expect statement of an STF file at all, the test infrastructure will do absolutely no checking of any packets that come out of those ports, whether 0 packets come out, or 1000.

@peteli3

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

added a question to Andy's comment in CMakeLists.txt
but lgtm

@mbudiu-vmw
Copy link
Collaborator

left a comment

I will merge this because I trust Andy and it blocks other tests from succeeding.

@mbudiu-vmw mbudiu-vmw merged commit 45707c3 into p4lang:master Apr 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
peteli3 added a commit to peteli3/p4c that referenced this pull request Jun 6, 2019
Make changes to 3 PSA tests that are causing the build to fail (p4lan…
…g#1862)

Two of them are passing now, and should be removed from the XFAIL list.

One of them was written in a way that it was passing, but it should
not have been.  Updated the STF test so it fails.  A separate PR on
behavioral-model code is required to make that test pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.