Skip to content

Loading…

log4j support #91

Closed
quintonm opened this Issue · 5 comments

2 participants

@quintonm
p6spy member

Migrated from sourceforge: https://sourceforge.net/p/p6spy/feature-requests/4/

add log4j support for the log files to take advantage
of all of logging options log4j offers

@typekpb
p6spy member

Log4j support is already implemented, this one should track a need to add proper junit tests.

As an extra idea, how about deprecating/not supporting options:

log4j.<property_name>

any more? As whoever is using log4j in his/her app would have own log4j config provided already and who wants can still configure log4j outside of p6spy properly.

I think we should focus on p6spy configuration, and keep log4j stuff as separate as possible.

Would that make sense?

@quintonm
p6spy member

Agreed. We should deprecate the log4j appender.

@typekpb
p6spy member

should be solved along with: #131

@typekpb
p6spy member

@quintonm as you already implemented: a7b3e48
would it make sence to completely remove the Log4jLogger, as well as the deprecated configuration (log4j.*)?
I think it causes us just trouble ( #170 ) and I'm not too much motivated to invest to something we plan to remove anyway.

We could close this one, as well as #170.

@quintonm
p6spy member
@typekpb typekpb was assigned
@typekpb typekpb closed this in 47f31c0
@typekpb typekpb added this to the 2.0.0 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.