-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move minimum PHP required version to PHP 7.4 #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pH-7
commented
Nov 2, 2021
•
edited
Loading
edited
- Moving away from the minimum required PHP version in favour of PHP 7.4. As pH7CMS 16.5.0 is dropping the support of PHP 5.6, all of the versions below PHP 7.4 won't be supported either anymore.
- Using more external packages to avoid duplicating code and reinventing the wheel.
https://github.com/pH-7/JustHttpStatusCodes `JustHttpStatusCodes` is lighter than HTTP Teapot package
Hi there, thanks very much for taking the time to open this issue! However, could you give more information about it? Please be as much as specific. Thank you! Pierre-Henry 🤖 |
pH-7
changed the title
Move minimum php required version
Move minimum PHP required version to PHP 7.2
Nov 2, 2021
pH-7
changed the title
Move minimum PHP required version to PHP 7.2
Move minimum PHP required version to PHP 7.4
Nov 4, 2021
…rExpression`
Add blank space between method declarations
As `version_compare()` can is not always very readable when reading the code quickly. That way, it will help a dev reading and understand the code even quicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.