Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the rule name match the reported error so we can ignore it. #209

Merged
merged 1 commit into from May 11, 2018

Conversation

wilco42
Copy link
Contributor

@wilco42 wilco42 commented May 10, 2018

When you try to ignore WCAG2AA.Principle1.Guideline1_4.1_4_3.G18, it doesn't get ignored. This is because there's a rule name mismatch and it is reported as WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail instead.

It's defined as WCAG2AA.Principle1.Guideline1_4.1_4_3.G18, but gets reported as WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
Copy link
Member

@rowanmanning rowanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wilco42, merging now

@rowanmanning rowanmanning merged commit edfd51a into pa11y:master May 11, 2018
romitzz1 pushed a commit to nicheinc/pa11y-dashboard that referenced this pull request Aug 19, 2021
…1y#209)

It's defined as WCAG2AA.Principle1.Guideline1_4.1_4_3.G18, but gets reported as WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants