Use Given Puppeteer Page Instance without page.goto()

[kevinatown]

Hey! I think it will be great for a way to tell pa11y to ignore the URL and not run page.goto() and just use the provided puppeteer page instance. This would allow for:

• a single puppeteer page instance to be programmed separately using puppeteer's own api
• once a page instance manipulated/rendered it can be verified using e2e tests and passed to pa11y

It should be trivial to implement; adding an option like ignoreUrl that defaults to false and requires a page instance.

[kevinatown]

Also I got a branch with what I was thinking and tests, it was super simple.

[hollsk]

Cool! We'd be happy to review a PR if you'd like to submit it 😄

[kevinatown]

@hollsk Thanks for your quick response, heres the PR. lmk what y'all think.

[hollsk]

Thanks @kevinatown ! Haven't had time for a proper look yet, hoping to do that on friday. From a quick scan it looks great though 😄

Will get back to you shortly!

[kevinatown]

Awesome! Let me know if there is anything I need to change!

[AndrewLeedham]

@hollsk Any movement on this. Would be a great addition.

[hollsk]

Yes, I agree! I need somebody with a bit more experience than I have to review, and I've been struggling to find somebody who has the time.

But I haven't forgotten about it, and I'm still on the lookout for a suitable reviewer, hoping to find somebody soon. Thanks for your patience 😄

[kevinatown]

@hollsk small bump on the status of the review

[thaffenden]

Would also love to use this if you have a chance to finish off the PR.

[hollsk]

No promises on timelines, but we've managed to get a bit of momentum on our backlog now, so hopefully we'll get back to this one soon.

Thanks for your patience, everyone - i know it's taken a while!

[joeyciechanowicz]

Closing as the PR is merged