review use of logging module for validation diagnostics #17

Closed
pabigot opened this Issue Jul 30, 2014 · 0 comments

Projects

None yet

1 participant

@pabigot
Owner
pabigot commented Jul 30, 2014

The logging module as used in PyXB's runtime system (as opposed to pyxbgen) should probably only be invoked on major errors, not to convey information that is otherwise provided through an exception.

@pabigot pabigot added this to the PyXB 1.2.4 milestone Aug 26, 2014
@pabigot pabigot self-assigned this Aug 26, 2014
@pabigot pabigot added a commit that closed this issue Oct 19, 2014
@pabigot fix #17: review use of logging module for validation diagnostics
Eliminated one case where a log message conveyed nothing that could not
be obtained from the exception that was immediately raised.

However, there are other warnings (cases where PyXB was unable to
validate a field, or when it found multiple valid parses) that do not
raise exceptions but are still important enough that they should be
visible by default.  Those will be retained at the current warning
level.  (Still more messages are present at info level, which is not
displayed by default and will not be removed.)
e35d3fa
@pabigot pabigot closed this in e35d3fa Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment