New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #979 #980

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
3 participants
@fmartelli
Contributor

fmartelli commented Sep 6, 2017

Handling AttributeConsumingServiceIndex into AuthnRequest

@mmoayyed

This comment has been minimized.

Show comment
Hide comment
@mmoayyed

mmoayyed Sep 6, 2017

Contributor

Excellent work. Thank you.

Contributor

mmoayyed commented Sep 6, 2017

Excellent work. Thank you.

@mmoayyed mmoayyed merged commit a83572f into pac4j:master Sep 6, 2017

5 checks passed

Scrutinizer No new issues
Details
codacy/pr Good work! A positive pull request.
Details
codebeat 1 issue resolved and 1 introduced
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leleuj

This comment has been minimized.

Show comment
Hide comment
@leleuj

leleuj Sep 6, 2017

Member

The change is fairly straightforward, but please try to think about updating the documentation next time (http://www.pac4j.org/docs/contribute.html#2-documentation).

Member

leleuj commented Sep 6, 2017

The change is fairly straightforward, but please try to think about updating the documentation next time (http://www.pac4j.org/docs/contribute.html#2-documentation).

@fmartelli

This comment has been minimized.

Show comment
Hide comment
@fmartelli

fmartelli Sep 6, 2017

Contributor
Contributor

fmartelli commented Sep 6, 2017

@mmoayyed

This comment has been minimized.

Show comment
Hide comment
@mmoayyed

mmoayyed Sep 7, 2017

Contributor

Updated docs.

Contributor

mmoayyed commented Sep 7, 2017

Updated docs.

@leleuj

This comment has been minimized.

Show comment
Hide comment
@leleuj

leleuj Sep 7, 2017

Member

Excellent! Thanks

Member

leleuj commented Sep 7, 2017

Excellent! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment