Skip to content

Improve/correct system menubar contrast #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Porkepix opened this issue Nov 16, 2023 · 0 comments · Fixed by #272
Closed

Improve/correct system menubar contrast #267

Porkepix opened this issue Nov 16, 2023 · 0 comments · Fixed by #272

Comments

@Porkepix
Copy link

Porkepix commented Nov 16, 2023 •
edited
Loading

Describe the bug
With default light and dark theme, system menubar can be difficult to read due to bad contrast. The black theme is fine on that end, see screenshots below.

Expected behavior
Make it easier to read by using better contrast between background color and text color.

Screenshots or video

Screenshots

Difficult contrasts
Screenshot_20231116-231313
Screenshot_20231116-231339

Black have a good contrast
Screenshot_20231116-231402

Versions
1.4.0 on Android Oreo stock (8.0)

EDIT: Note that it's more difficult to realize from these screenshots where the contrast is actually much better than on a live phone.
nikclayton added a commit to nikclayton/pachli-android that referenced this issue Nov 20, 2023
@nikclayton
fix: Use transparent system bar on all Android versions
6112959 
Previous code use transparent system bars on v29, resulting in the
wrong colours in preferences and other activities on some devices.

Fixes pachli#267
@nikclayton nikclayton mentioned this issue Nov 20, 2023
Merged
nikclayton added a commit that referenced this issue Nov 20, 2023
@nikclayton
fix: Use transparent system bar on all Android versions (#272)
a6a68f1 
Previous code use transparent system bars on v29, resulting in the wrong
colours in preferences and other activities on some devices.

Fixes #267
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pachli roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use transparent system bar on all Android versions nikclayton/pachli-android
1 participant
@Porkepix