Repository navigation
fix: Restore the user's reading position under all circumstances - #133
Merged
Merged
Conversation
The previous code did not always work when the user returned to the app after a lengthy absence (e.g., overnight). Instead of restoring by scrolling in `TimelineFragment`, restore by working with the platform. Determine the initial page to fetch by looking half a page ahead of the saved saved status ID, and fetch that status and the page immediately prior. This seems to match the view's expectations about what will be immediately available. Set `jumpThreshold` and `enablePlaceholders` in the `PagingConfig` so the paging system will jump to the saved status. Remove the restoration code in `TimelineFragment`. Fixes pachli#53
This was referenced Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code did not always work when the user returned to the app after a lengthy absence (e.g., overnight).
Instead of restoring by scrolling in
TimelineFragment, restore by working with the platform.Determine the initial page to fetch by looking half a page ahead of the saved saved status ID, and fetch that status and the page immediately prior. This seems to match the view's expectations about what will be immediately available.
Set
jumpThresholdandenablePlaceholdersin thePagingConfigso the paging system will jump to the saved status.Remove the restoration code in
TimelineFragment.Fixes #53