fix: Adjust video playback UX behaviour #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, playing a video would show the controls and associated overlay for five seconds before fading them out. This obscures the video for too long. Fix this by: - Only showing the media description on start, and remove after two seconds - Show the controls (and media description) if the user taps, removing after two seconds - Pausing the video (with the pause control, or tapping on the media description) keeps the controls and description on-screen indefinitely so they are easier to read Fixes pachli#144
sanao1006
pushed a commit
to sanao1006/pachli-android
that referenced
this pull request
Oct 20, 2023
Previously, playing a video would show the controls and associated overlay for five seconds before fading them out. This obscures the video for too long. Fix this by: - Only showing the media description on start, and remove after two seconds - Show the controls (and media description) if the user taps, removing after two seconds - Pausing the video (with the pause control, or tapping on the media description) keeps the controls and description on-screen indefinitely so they are easier to read Fixes pachli#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, playing a video would show the controls and associated overlay for five seconds before fading them out. This obscures the video for too long.
Fix this by:
Fixes #144