Skip to content

fix: Improve display of "obscured" links - #194

Merged
nikclayton merged 1 commit into
pachli:mainfrom
nikclayton:obscured-link-emoji
Oct 23, 2023
Merged

nikclayton merged 1 commit into
pachli:mainfrom
nikclayton:obscured-link-emoji

Conversation

@nikclayton

Copy link
Copy Markdown
Contributor

The previous code (a) used an emoji as the prefix character when showing the destination of an obscured link, and (b) made the destination part of the link anchor text.

Using an emoji was a problem because the user can use different emoji sets and it can give strange results. Making the destination part of the link text made it difficult to distinguish at a glance where one link ends and another starts.

Fix the emoji problem by replacing the emoji with a drawable.

Fix the destination problem by changing the string resource so it only includes the destination part, and inserting it at the end of the link instead of replacing the whole link. This means the disclosed destination is not clickable, does not look like part of the link, and stands out more.

The previous code (a) used an emoji as the prefix character when showing
the destination of an obscured link, and (b) made the destination part
of the link anchor text.

Using an emoji was a problem because the user can use different emoji
sets and it can give strange results. Making the destination part of
the link text made it difficult to distinguish at a glance where one
link ends and another starts.

Fix the emoji problem by replacing the emoji with a drawable.

Fix the destination problem by changing the string resource so it only
includes the destination part, and inserting it at the end of the link
instead of replacing the whole link. This means the disclosed
destination is not clickable, does not look like part of the link, and
stands out more.
@nikclayton
nikclayton merged commit 5a41cbd into pachli:main Oct 23, 2023
@nikclayton
nikclayton deleted the obscured-link-emoji branch October 23, 2023 11:20
@nikclayton nikclayton added this to the 1.3 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant