Repository navigation
fix: Improve display of "obscured" links - #194
Merged
Merged
Conversation
The previous code (a) used an emoji as the prefix character when showing the destination of an obscured link, and (b) made the destination part of the link anchor text. Using an emoji was a problem because the user can use different emoji sets and it can give strange results. Making the destination part of the link text made it difficult to distinguish at a glance where one link ends and another starts. Fix the emoji problem by replacing the emoji with a drawable. Fix the destination problem by changing the string resource so it only includes the destination part, and inserting it at the end of the link instead of replacing the whole link. This means the disclosed destination is not clickable, does not look like part of the link, and stands out more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code (a) used an emoji as the prefix character when showing the destination of an obscured link, and (b) made the destination part of the link anchor text.
Using an emoji was a problem because the user can use different emoji sets and it can give strange results. Making the destination part of the link text made it difficult to distinguish at a glance where one link ends and another starts.
Fix the emoji problem by replacing the emoji with a drawable.
Fix the destination problem by changing the string resource so it only includes the destination part, and inserting it at the end of the link instead of replacing the whole link. This means the disclosed destination is not clickable, does not look like part of the link, and stands out more.