fix: Prevent UnsupportedOperationException in PachliTileService #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code always called `startActivityAndCollapse()` with a regular intent, which triggers an `UnsupportedOperationException` at API 34. Use the non-deprecated variant that uses pending intents when appropriate. While looking at this I noticed the icon for the tile was incorrect, so replaced that with the notification icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code always called
startActivityAndCollapse()with a regular intent, which triggers anUnsupportedOperationExceptionat API 34.Use the non-deprecated variant that uses pending intents when appropriate.
While looking at this I noticed the icon for the tile was incorrect, so replaced that with the notification icon.