fix: Show edit history for status' with polls #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited polls only include the list of options with titles; no other metadata (poll ID, single/multiple choice, vote counts, etc). Since the data shape didn't match Moshi wasn't decoding the data. Provide dedicated data classes to model the response, and add a fourth poll display option to represent viewing an edit history snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited polls only include the list of options with titles; no other metadata (poll ID, single/multiple choice, vote counts, etc). Since the data shape didn't match Moshi wasn't decoding the data.
Provide dedicated data classes to model the response, and add a fourth poll display option to represent viewing an edit history snapshot.