fix: Prompt user to save/discard changes after editing bio #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code didn't get the viewmodel to check if the content had changed, so `onBackPressedCallback` wasn't enabled, and the user could edit the bio and press "back" without being prompted to save their changes.
Contributor
Author
|
/cc @mileskrell |
nikclayton
added a commit
to nikclayton/pachli-android
that referenced
this pull request
Jun 10, 2024
Previous code didn't get the viewmodel to check if the content had changed, so `onBackPressedCallback` wasn't enabled, and the user could edit the bio and press "back" without being prompted to save their changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code didn't get the viewmodel to check if the content had changed, so
onBackPressedCallbackwasn't enabled, and the user could edit the bio and press "back" without being prompted to save their changes.