fix: Ensure trending tag name is fully visible#831
Merged
nikclayton merged 1 commit intopachli:mainfrom Jul 22, 2024
Merged
Conversation
Previously re-binding the tag's text wouldn't re-measure the layout when the text changed. So scrolling down a longer tag could be placed in a textview that previously held a shorter tag. Then it was cut off and the user couldn't see what the tag was. Use `wrap_content` so size is measured when the content changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously re-binding the tag's text wouldn't re-measure the layout when the text changed. So scrolling down a longer tag could be placed in a textview that previously held a shorter tag.
Then it was cut off and the user couldn't see what the tag was. Use
wrap_contentso size is measured when the content changes.