Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a release #15

Closed
ashcrow opened this issue May 28, 2019 · 6 comments

Comments

@ashcrow
Copy link
Contributor

commented May 28, 2019

Right now we are not doing releases of packageurl-go. We should. Cut a release once the current set of issues have been run through and travis is passing.

@ashcrow ashcrow added the enhancement label May 28, 2019

@ashcrow ashcrow self-assigned this May 28, 2019

@petergardfjall

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

I think we are fairly close to this after #16.
I'm not sure if you're have merge rights in the https://github.com/package-url/purl-spec repo, but as mentioned in the pull request, we need package-url/purl-spec#61 merged before all tests will pass.

@fitzoh

This comment has been minimized.

Copy link

commented Sep 10, 2019

Any updates now that #16 is complete?

@ashcrow

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@ashcrow ashcrow closed this Sep 10, 2019

@petergardfjall

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@ashcrow Great news, however, in order for the release to play well with the Go module system, it needs to be prefixed by a v. So please change the tag from 0.1.0 to v0.1.0.

@ashcrow

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@petergardfjall

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

@ashcrow Thanks, I've verified that it works with Go modules. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.