Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Make PackageURL.ToString() deterministic #7
A parsed PackageURL should preserve the order of qualifiers (as in the parsed
This commit changes the type of Qualifiers into
to preserve qualifier ordering.
The tests are also updated to ensure that qualifiers are read in
PackageURL is also made to implement the Stringer interface, which is idiomatic
@ashcrow Thanks for taking the time to look at the PR. I seem to remember that a few of the tests were failing even before I added this fix. So I decided not to broaden the scope of the PR to address that. But I'm not sure if my memory serves me well on this one. I can have another look tomorrow.
@ashcrow I just ran the tests on
The same problems can be observed in the travis builds: https://travis-ci.org/package-url/packageurl-go/jobs/514173724