Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic #8

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
2 participants
@furuholm
Copy link
Contributor

commented Apr 1, 2019

This change replaces usage of panic with errors (https://github.com/golang/go/wiki/CodeReviewComments#dont-panic)

@furuholm

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@ashcrow

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Thank you for the PR! This is a great idea, though it looks like the fmt.Errorf's are not being returned back up (aka they are being created but not used).

@ashcrow ashcrow self-assigned this May 14, 2019

Don't panic
This change replaces usage of panic with errors (https://github.com/golang/go/wiki/CodeReviewComments#dont-panic)

@furuholm furuholm force-pushed the furuholm:dont_panic branch from fdc51f6 to 0feaba9 May 20, 2019

@furuholm

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Silly mistake. Sorry!
I have (force) pushed a fix.

@ashcrow ashcrow added the enhancement label May 20, 2019

@ashcrow

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@furuholm no worries!! Some tests fail, but I will fix them after the fact.

@ashcrow
Copy link
Contributor

left a comment

Some tests fail, but I can fix them in a follow up.

@ashcrow

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@pombredanne looks like I've lost the ability to merge. Just verifying that's expected.

@ashcrow

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@pombredanne Oops, I didn't have enough ☕️. I have the ability to merge.

@ashcrow ashcrow merged commit 7fb44e4 into package-url:master May 20, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.