-
Notifications
You must be signed in to change notification settings - Fork 54
update allowed_qualifiers typing #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bollwyvl thanks for the PR, CI is failing. Please check. Thanks! |
|
Updated with legacy |
|
CI fails, check please https://github.com/package-url/packageurl-python/actions/runs/19640491246/job/56242359760?pr=213. Thanks for a quick turnaround. |
|
|
TG1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@bollwyvl can you please add a changelog entry for same? |
|
Added changelog entry. Some observations as a drive-by contributor, it would be lovely if:
|
@bollwyvl sure, I am opening a follow-up issue on this. |
|
Thanks! |
Thanks for this package, and congratulations on 0.17.6!
Noted on conda-forge/packageurl-python-feedstock#40, this minor typing nitpick to
allowed_qualifiersshould allow e.g.mypyto pass.the current
mypyfindings...