-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the "docker/build-push-action" documentation, any changes made to files preceding this Action will be discarded / ignored. As a result, any resolved git LFS files will be ignored. Because the repo. contains one or more git LFS'ed tar file, the file(s) created by the "checkout" action will be returned to LFS pointer text files when the "build-push" action runs. This does not bode well for the Docker image build process, which attempts to untar said pointer files. Refer to the following URLs for more information: - https://github.com/docker/build-push-action/#usage - https://stackoverflow.com/a/66453723
The "docker/metadata" Action is pretty unclear about this... Refer to the following URL for more information: - https://github.com/docker/metadata-action#tags-input
nshalman
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
This would probably be cleaner squashed down to a single commit before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the drone CI configuration to GitHub Actions.