Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picking up packit.yml from target branch vs. from the PR #48

Open
TomasTomecek opened this issue Jul 15, 2019 · 3 comments

Comments

@TomasTomecek
Copy link
Contributor

commented Jul 15, 2019

  • document current behaviour packit-service/packit.dev#31
  • let upstream maintainers define how p-s should pick up the config file (PR vs. target branch)

CC @dmach

TomasTomecek added a commit to TomasTomecek/packit.dev that referenced this issue Jul 15, 2019

document how p-s picks up config file
Related packit-service/packit-service#48

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@lachmanfrantisek

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

let upstream maintainers define how p-s should pick up the config file (PR vs. target branch)

Do we want this?

@rpitonak rpitonak changed the title picking up packit.xml from target branch vs. from the PR picking up packit.yml from target branch vs. from the PR Aug 15, 2019

@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

let upstream maintainers define how p-s should pick up the config file (PR vs. target branch)

Do we want this?

That's the question and worth a discussion.

@lachmanfrantisek

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Personally, I am used to the config from PR, as it is in zuul/gitlab-ci/... I am able to play with the CI easily.

(I have only one problem with that with signature checking that has to be used from master. But there, we are using the downstream config.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.