Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoprBuildHandler refactor and support for target aliases #277

Merged

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Dec 4, 2019

  • refactor of the 'CoprBuildHandler' class
  • support for using aliases for targets
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch 3 times, most recently from 24a5bf6 to 748f1b4 Dec 4, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build failed.

Copy link
Member

jpopelka left a comment

🚀 happy to see I'm not the only refactoring freak here

Copy link
Contributor

TomasTomecek left a comment

oh boy, the rebase's gonna give me so much nightmares

after a brief look, the changes look nice

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from 748f1b4 to 332f7ca Dec 4, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

@jpopelka jpopelka added the mergeit label Dec 4, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 41667c0 into packit-service:master Dec 4, 2019
4 checks passed
4 checks passed
ci/dockercloud Your tests passed in Docker Cloud
Details
ci/dockercloud (/Dockerfile.worker) Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:aliases branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.