Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/packit build alias #290

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Dec 6, 2019

  • Allow '/packit build' to trigger the copr-build as well.
@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Dec 6, 2019

it's / right? not \

Copy link
Contributor

TomasTomecek left a comment

2 things:

  • this needs docs, obviously
  • should we advertise in the build-failed-you-need-retrigger comment this over copr-build?
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 6, 2019

Build succeeded.

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 6, 2019

  • this needs docs, obviously

👍

  • should we advertise in the build-failed-you-need-retrigger comment this over copr-build?

Good point.

  • build: When there is no copr-build defined and if it is built because of the tests.
    • (="I don't want to know anything about copr." workflow)
  • copr-build: When there is a copr-build defined in the jobs.
    • (="I am interested in copr." workflow)

it's / right? not \

Thanks, the wrong slash is only in the git message and PR title. (edit: fixed)

@lachmanfrantisek lachmanfrantisek changed the title \packit build alias /packit build alias Dec 6, 2019
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:build-alias branch from 0ada0e3 to 11f1866 Dec 6, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 6, 2019

Build succeeded.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:build-alias branch from 11f1866 to b5bd7ad Dec 6, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 6, 2019

Build succeeded.

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 6, 2019

  • About the docs: @TomasTomecek, you mean packit.dev documentation, right?
  • About the re-trigger message: Can we change that when there will be support for defining tests without copr-build jobs?
@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Dec 6, 2019

* `build`: When there is no `copr-build` defined and if it is built because of the tests.
  
  * (="I don't want to know anything about copr." workflow)

* `copr-build`: When there is a `copr-build` defined in the jobs.
  
  * (="I am interested in copr." workflow)

sounds good!

* About the docs: @TomasTomecek, you mean `packit.dev` documentation, right?

yep

* About the re-trigger message: Can we change that when there will be support for defining tests without `copr-build` jobs?

sounds good! would be nice to track that request somewhere

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 6, 2019

sounds good! would be nice to track that request somewhere

I'll create a new issue.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 6, 2019

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 60db10b into packit-service:master Dec 6, 2019
4 checks passed
4 checks passed
ci/dockercloud Your tests passed in Docker Cloud
Details
ci/dockercloud (/Dockerfile.worker) Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:build-alias branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.